Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add q to toggle the pager. #5052

Merged
merged 2 commits into from Feb 8, 2014
Merged

Add q to toggle the pager. #5052

merged 2 commits into from Feb 8, 2014

Conversation

ellisonbg
Copy link
Member

Fixes #5000

@ellisonbg ellisonbg added this to the 2.0 milestone Feb 6, 2014
@ellisonbg ellisonbg self-assigned this Feb 6, 2014
@takluyver
Copy link
Member

I'm not sure about using it to toggle the pager - pressing q to bring the pager up seems weird.

@ellisonbg
Copy link
Member Author

I was hoping someone would pick up this choice. I agree it is weird. Two options:

  • a) Just use q for close.
  • b) Pick a different key for toggle.

Thoughts. I honestly love to have a single key the did both (toggle).

@ivanov
Copy link
Member

ivanov commented Feb 7, 2014

I prefer option (a) for quitting the pager, having a toggleable pager seems weird to me.

@minrk
Copy link
Member

minrk commented Feb 7, 2014

+1 to just close

@ellisonbg
Copy link
Member Author

OK I will change this.

@ellisonbg
Copy link
Member Author

Comments addressed, ready for merge.

ellisonbg added a commit that referenced this pull request Feb 8, 2014
@ellisonbg ellisonbg merged commit 07d1ed5 into ipython:master Feb 8, 2014
@ellisonbg ellisonbg deleted the pager-q branch February 8, 2014 19:52
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closing pager with keyboard in modal UI
4 participants