Refactor keyboard handling

[ellisonbg]

Fixes #4886

This creates a new JS module as base/keyboard.js exposed as IPython.keyboard for all of our keyboard handling. This is meant to replace the keyboard related stuff in IPython.utils. But the removal of the old stuff will come later once we have better tests in place. This should wait for #5053 so tests of keyboard.js can be added.

[takluyver]

@ellisonbg I see #5053 has gone in, and you have added some tests for keyboard.js. Do you want to add some more now, or is this ready for review?

[ellisonbg]

This is ready for review. We can add more tests over time, but this is a
good start for the core of it.

On Fri, Feb 14, 2014 at 11:57 AM, Thomas Kluyver
notifications@github.comwrote:

@ellisonbg https://github.com/ellisonbg I see #5053https://github.com/ipython/ipython/pull/5053has gone in, and you have added some tests for keyboard.js. Do you want to
add some more now, or is this ready for review?

Reply to this email directly or view it on GitHubhttps://github.com//pull/5076#issuecomment-35118813
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[minrk]

This is ready for review.

Did you want to get the tests passing, first?

[ellisonbg]

Hmm, that is odd, this shouldn't have changed anything that would affect
existing tests, but I will look into it (I guess this is why we have test :)

On Fri, Feb 14, 2014 at 10:36 PM, Min RK notifications@github.com wrote:

This is ready for review.

Did you want to get the tests passing, first?

Reply to this email directly or view it on GitHubhttps://github.com//pull/5076#issuecomment-35148851
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[ellisonbg]

OK, rebased, tests passing and ready for final review.

[minrk]

I thought I already merged this one...Merging now.

[ellisonbg]

Yes, I forgot about it myself - it needed rebasing. Thanks!

On Mon, Mar 3, 2014 at 2:54 PM, Min RK notifications@github.com wrote:

Merged #5076 #5076.

Reply to this email directly or view it on GitHubhttps://github.com//pull/5076
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com