Updating JS tests README.md #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm @takluyver @jdfreder @minrk there is a weird test failure in this branch on Travis that looks new and unusual. It looks like two notebook servers are trying to start at the same time. I am wondering if this is related to the JS test refactor. I am starting to switch gears to Strata talk preparation, could one of you look into this? |
|
Yup, the js test changes seem to cause one server to start for each sub-group. I'll look into it. |
|
Actually, no - it looks like there is just a print statement in the wrong place. See #5083 |
|
Thanks for the fix, I merged it. I also rebased and Travis is running again. Once tests pass this one is ready to go. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Updating JS tests README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.