Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Two displayhooks in zmq #512

Closed
takluyver opened this Issue · 2 comments

2 participants

@takluyver
Owner

The ZMQShell uses a ZMQDisplayHook object defined in IPython/zmq/zmqshell.py, which inherits from the DisplayHook in core. But there's also a DisplayHook defined separately in IPython/zmq/displayhook.py, which seems to be used by the parallel engine.

This is a little confusing - the two classes should probably both be in IPython/zmq/displayhook.py, and could also have clearer names - perhaps ZMQDisplayHook and ZMQRichDisplayHook.

@minrk
Owner

The hook in zmq.displayhook is a generic one that could be used any time you want to forward display over zeromq. The hook in zmq.zmqshell is a subclass that adds the extra bits an InteractiveShell expects.

I don't see a reason not to put them both in zmq.displayhook. I wouldn't choose RichDisplayHook as the name for the InteractiveShell-bound one. Maybe ZMQDisplayHook and ZMQShellDisplayHook, since the latter is for use in the ZMQShell?

@minrk
Owner

this was closed by PR #527

@minrk minrk closed this
@damianavila damianavila referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.