Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page jumping when output from widget interaction replaced #5128

Closed
takluyver opened this issue Feb 14, 2014 · 3 comments · Fixed by #5459
Closed

Page jumping when output from widget interaction replaced #5128

takluyver opened this issue Feb 14, 2014 · 3 comments · Fixed by #5459
Assignees
Labels
Milestone

Comments

@takluyver
Copy link
Member

Testing Fernando's demo notebook, I see odd jumping when I drag the slider:

<iframe width="420" height="315" src="//www.youtube.com/embed/qiFbzvCclBs?rel=0" frameborder="0" allowfullscreen></iframe>

www.youtube.com/watch?v=qiFbzvCclBs

@jdfreder
Copy link
Member

I'm able to reproduce this on FF 25+, but not Chrome. Problem seems to exist regardless of which cell starts with focus. It's really strange that it jumps after a delay... This suggests there is still a lingering setTimeout, which I thought we ( @ellisonbg and I ) removed all of these. hmm...

@ellisonbg
Copy link
Member

Hmm, I thought we removed those too...

@jdfreder jdfreder self-assigned this Mar 28, 2014
@jdfreder
Copy link
Member

Assigning this to myself

minrk added a commit that referenced this issue Apr 9, 2014
Firefox doesn't render images immediately as the data is available.  When animating the way that we animate, this causes the output area to collapse quickly before returning to its original size.  When the output area collapses, FireFox scrolls upwards in attempt to compensate for the lost vertical content (so it looks like you are on the same spot in the page, with respect to the contents below the image's prior location).  The solution is to resize the image output after the `img onload` event has fired.

This PR:
- Releases the `clear_output` height lock after the image has been loaded (instead of immediately or using a timeout).
- Removes a `setTimeout` call in the `append_output` method.
- `clear_output` in zmqshell no longer sends `\r` to the stream outputs.

closes #5128
@minrk minrk added this to the 2.1 milestone Apr 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants