Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horisontal scrollbar overlaps output or touches next cell #5192

Closed
drevicko opened this issue Feb 21, 2014 · 6 comments · Fixed by #5843
Closed

horisontal scrollbar overlaps output or touches next cell #5192

drevicko opened this issue Feb 21, 2014 · 6 comments · Fixed by #5843
Assignees
Milestone

Comments

@drevicko
Copy link
Contributor

overlaps output:
ipython notebook horisontal scroll overlaps output

touches next cell (note: here no print statements were executed, no output generated):
ipython notebook horisontal scroll touches next cell

firefox 27.0.1 on Ubuntu 12.04
head version of ipython yesterday, i believe it's d5ccd94

@takluyver
Copy link
Member

@jdfreder I've assigned this to you because I know you've spent quite a bit of time fiddling with it already.

@jdfreder
Copy link
Member

Thanks, I'll take a look.

@jdfreder
Copy link
Member

jdfreder commented Apr 9, 2014

#5446 should close this

@drevicko
Copy link
Contributor Author

Strange. The problem is fixed when I checkout your (@jdfreder) 'scrollbar' branch .. However when I checkout the SHA in my bug report, it also works!... also when I checkout head. I cleared the browser cache, checked I'm running ipython in my virtualenv for the dev version, checked that the ipython.egg-link points at my local git repo...

Well, firefox is now version 28.0, could that have changed things? I could try rolling it back (apt would do that I guess?), but perhaps it's not worth the bother. It's a little unsettling that I can't reproduce the bug though!

One cosmetic thing I might suggest if it's easy to do: add a little padding to on the right of the cell content. When scrolled to the far right, the longest line touches the boundary of the cell.

@drevicko
Copy link
Contributor Author

Not sure what was going on with caching, but I verified on another machine that the scrollbar branch fixes this, and now back on the first machine I can make the problem come and go by switching between ipython/master and jdfreder/scrollbar.

I guess we should wait for #5446 to be merged before closing?

@jdfreder
Copy link
Member

I guess we should wait for #5446 to be merged before closing?

I added this issue to the list, GH will auto close it when #5446 gets merged. I'm hoping it will get merged during PyData or shortly there after.

minrk added a commit to minrk/ipython that referenced this issue May 12, 2014
The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to *introduce* incorrect behavior

closes ipython#5192
closes ipython#5364
@minrk minrk added this to the 2.1 milestone May 15, 2014
minrk added a commit that referenced this issue May 16, 2014
The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to *introduce* incorrect behavior

closes #5192
closes #5364
schodge pushed a commit to schodge/ipython that referenced this issue Jun 3, 2014
The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to *introduce* incorrect behavior

closes ipython#5192
closes ipython#5364
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to *introduce* incorrect behavior

closes ipython#5192
closes ipython#5364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants