Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output images appear as small thumbnails (Notebook) #5219

Closed
ghost opened this issue Feb 25, 2014 · 10 comments · Fixed by #5223
Closed

Output images appear as small thumbnails (Notebook) #5219

ghost opened this issue Feb 25, 2014 · 10 comments · Fixed by #5223
Milestone

Comments

@ghost
Copy link

ghost commented Feb 25, 2014

When opening a notebook, most images in the notebook are shown as 24 x 24 (px) images. They are resizable, but the aspect ratio is wrong. There is not a custom.js being used, and I have the issue with XP/Firefox and Win7/Chrome.

The images become the correct size when the notebook page is reloaded. This issue was discussed on the HipChat help about a half hour before this posting.

@minrk
Copy link
Member

minrk commented Feb 25, 2014

I've never seen this myself, but @takluyver did the other day. Of course, when we started trying to debug it, it stopped happening. Will keep an eye out for it. I suspect it's the resizing code that's measuring incorrectly at load.

Does refreshing the page improve the situation?

@minrk minrk added this to the 2.0 milestone Feb 25, 2014
@ghost
Copy link
Author

ghost commented Feb 25, 2014

Refreshing the page, so far, has fixed all the images. I notice that on some of my notebooks (with lots of images) some of the images will be fine at the start, while others will be the very small versions.

@minrk
Copy link
Member

minrk commented Feb 25, 2014

Thanks, I think that's what @takluyver was seeing. I'll see if I can reproduce, so I can start investigating a fix.

@rizar
Copy link

rizar commented Feb 25, 2014

The same bug on my machine, Ubuntu 13.10, ipython 1.1.0. Refreshing solves the problem (thanks!).

@ghost
Copy link
Author

ghost commented Feb 25, 2014

I should have stated that I had the issue with 1.1.0 and 1.2.1.

@takluyver
Copy link
Member

I think our guess was that the js resizing thing was measuring the size of the image before the actual image data was loaded, and 24x24 represented some default minimum size. When you reload, the images are cached, so they load before the js measures them. We didn't confirm that, though.

minrk added a commit to minrk/ipython that referenced this issue Feb 25, 2014
instead of timeout, which could get incorrect size information.

closes ipython#5219
@minrk
Copy link
Member

minrk commented Feb 25, 2014

Should be fixed by #5223.

minrk added a commit to minrk/ipython that referenced this issue Mar 1, 2014
instead of timeout, which could get incorrect size information.

closes ipython#5219
@ellisonbg
Copy link
Member

@JamesArruda can you confirm that #5223 fixes the issue for you?

@ghost
Copy link
Author

ghost commented Mar 3, 2014

Confirmed. I'm not seeing the small image problem any more.

@ellisonbg
Copy link
Member

Great, thanks!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
instead of timeout, which could get incorrect size information.

closes ipython#5219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants