Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript("element.append()") looks broken. #5293

Closed
dalejung opened this issue Mar 8, 2014 · 1 comment · Fixed by #5430
Closed

Javascript("element.append()") looks broken. #5293

dalejung opened this issue Mar 8, 2014 · 1 comment · Fixed by #5430
Labels
Milestone

Comments

@dalejung
Copy link
Contributor

dalejung commented Mar 8, 2014

So something like

Javascript("element.append($('<a href=\"#\">Link</a>'))")

Creates a link that is flushed to the right due to the flex hbox. Appending to toinsert works as I would expect. Not sure if element referring to output_area is a bug or API change since it was explicitly done here 0ea988b

dalejung added a commit to dalejung/nbx that referenced this issue Mar 8, 2014
@minrk
Copy link
Member

minrk commented Mar 8, 2014

I don't think this change was necessarily intentional. I can't see a good reason why this was changed (probably for code consistency across append methods, since none of the other methods expose APIs based on their internal variable names).

@minrk minrk added this to the 2.0 milestone Mar 8, 2014
jdfreder added a commit to jdfreder/ipython that referenced this issue Mar 25, 2014
Zaharid pushed a commit to Zaharid/ipython that referenced this issue Apr 22, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants