Remove unused configobj and validate libraries from externals. #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go for it. The more we remove unused stuff, the better the chances of a clean 0.11 release. Nobody should depend on our externals anyway, so this is fair game. Thanks! |
|
Rebased and merged. For now, I've been conservative and only removed the completely unused stuff - I haven't touched the libraries that are used in deathrow and quarantine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These libraries weren't actually being used anywhere. All tests still pass.
Also on the hitlist, but not yet removed: mglob and guid only seem to be used in deathrow and quarantine. Also, pyparsing isn't used anywhere, but it's mentioned in a docstring in core.prefilter that it's available.