Handle unicode properly in IPython.zmq.iostream #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| import logging | |||
| import sys | |||
| import time | |||
| from cStringIO import StringIO | |||
| from io import StringIO | |||
There was a problem hiding this comment.
Why not use the more efficient cStringIO?
There was a problem hiding this comment.
They do different things - io.StringIO expects Unicode (i.e. it's forwards compatible with Python 3). It's also actually written in C - the Python io module just exports it from the C _io module.
There was a problem hiding this comment.
...OK, it's possibly moved into C for 2.7.
There was a problem hiding this comment.
Sounds good, as long as there is a reason.
|
This makes sense - the forcing of bytes doesn't make sense anymore, because these are real (JSON-style) messages now. Presumably at some point they were basic pyzmq sends, which can't support unicode. Go ahead and merge this one. |
|
Thanks, Min. Rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jstenar says this fixes printing Unicode at the Qt console in Windows (issue #529). It also makes sense in terms of the code, fixing a broken design I'd put in place some time ago.