Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal scrollbar hides cell's last line on Firefox #5364

Closed
astrojuanlu opened this issue Mar 16, 2014 · 15 comments · Fixed by #5843
Closed

Horizontal scrollbar hides cell's last line on Firefox #5364

astrojuanlu opened this issue Mar 16, 2014 · 15 comments · Fixed by #5843
Assignees
Milestone

Comments

@astrojuanlu
Copy link
Contributor

In Firefox under Linux, when the cell contents are too wide the horizontal scrollbar hides the last line:

cell_issue_ff

@takluyver
Copy link
Member

One of @jdfreder's favourite bugs. Which version of IPython are you using?

@astrojuanlu
Copy link
Contributor Author

I'm using 2.0.0beta1 on Python 3.

@ivanov
Copy link
Member

ivanov commented Mar 20, 2014

IIRC I've seen this happen when zoomed in more than 100% before. Are you able to get this with just a really long line every time? Also, what is your monospace font set to?

@astrojuanlu
Copy link
Contributor Author

I have tried again with IPython 1.2 and I am unable to reproduce this (the global horizontal scrollbar appears at the bottom of the browser), whereas every single time I put a long line the per-cell scrollbar hides the last one.

In both Firefox and Chromium the rendered font is DejaVu Sans Mono, but the failure appears only in Firefox.

@jdfreder
Copy link
Member

I wrote this JS fiddle that reproduces the behavior (see the red box):
http://jsfiddle.net/tZVsS/211/

This is behavior is caused by this line:
https://github.com/ipython/ipython/blob/master/IPython/html/static/notebook/less/codemirror.less#L29

Which fixes this bug:
#3549

Which I still can't reproduce in Firefox 25+. If I was able to reproduce #3549, I would write a fiddle and open an issue with CodeMirror. Pinging @juhasch and @minrk since they were able to reproduce #3549 .

@jdfreder jdfreder added this to the 3.0 milestone Mar 26, 2014
@juhasch
Copy link
Contributor

juhasch commented Mar 27, 2014

So this is what happens in a notebook codecell with overflow-x: auto.
Nothing selected:
before

One line or more selected:
after

The top: value changes. This is the same in your JS fiddle, although the codemirror div doesn't change size like it does in a codecell.

@juhasch
Copy link
Contributor

juhasch commented Mar 27, 2014

I need to add: It is exactly the same with overflow-x: hidden, i.e. I see no difference at all in the HTML, just in the browser display...

@jdfreder
Copy link
Member

Hmmm. I do see that the top value changes depending on where the cursor is in the document (line selected or not). I'm guessing that that div has something to do with the cursor's current location.

Looking at the code that the element inspector shows, it's interesting that that is the only changing variable (I'm looking at it too).

@pybokeh
Copy link

pybokeh commented Apr 7, 2014

I just want to report I am having this same problem as well with IPython version 2.0, Firefox version 28. When I switch to using Chrome, this is not a problem.

@jdfreder
Copy link
Member

jdfreder commented Apr 7, 2014

#5446 should fix it

@mbewley
Copy link

mbewley commented Apr 29, 2014

I get this on IPython 2.0, ubuntu and firefox 28.0. It's a real pain, because whenever I resize the window (e.g. to have a notebook open on the right half of the screen), I lose most of the last line in any cell with decent line length.
Any chance of the fix making it into a patch for 2.0? I'm trying to run just official releases now in production.

@drevicko
Copy link
Contributor

I can confirm that #5446 (jdreder's scrollbar branch) fixes this.

minrk added a commit to minrk/ipython that referenced this issue May 12, 2014
The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to *introduce* incorrect behavior

closes ipython#5192
closes ipython#5364
@minrk minrk modified the milestones: 2.1, 3.0 May 15, 2014
minrk added a commit that referenced this issue May 16, 2014
The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to *introduce* incorrect behavior

closes #5192
closes #5364
schodge pushed a commit to schodge/ipython that referenced this issue Jun 3, 2014
The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to *introduce* incorrect behavior

closes ipython#5192
closes ipython#5364
@CarloNicolini
Copy link

Same problem, Firefox 29, IPython 2.0, Ubuntu 12.04.4.
Will it be fixed in the next release?

@minrk
Copy link
Member

minrk commented Jun 4, 2014

This should be fixed in IPython 2.1, released a week or so ago.

@drevicko
Copy link
Contributor

Just an FYI that this problem seems to exist in firefox (29.0.1) on OSX (10.8.5). A little different here, as the scrollbar is invisible until you scroll. I recall some other odd behavior with horisontal scrolling too (can't recall right now), been meaning to put in a bug, but have been busy with other things..

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to *introduce* incorrect behavior

closes ipython#5192
closes ipython#5364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants