Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearing message handlers on status=idle loses async output #5407

Closed
minrk opened this issue Mar 22, 2014 · 0 comments · Fixed by #5668
Closed

clearing message handlers on status=idle loses async output #5407

minrk opened this issue Mar 22, 2014 · 0 comments · Fixed by #5668
Labels
Milestone

Comments

@minrk
Copy link
Member

minrk commented Mar 22, 2014

It is possible for output to arrive on IOPub after the status=idle message.
Currently, we clear message handlers on the idle message, in order to keep that data structure from growing indefinitely, but the result is lost async output that would previously work just fine in 1.0.

My first idea for a fix would be to let cells unregister the handlers on clear output, etc., but this doesn't solve the issue for comms and widgets, which are the main reason for the patch. Perhaps a more generic notion of owners, and only allowing one outstanding msg_id per owner would allow the right behavior.

@minrk minrk added this to the 3.0 milestone Mar 22, 2014
@minrk minrk modified the milestones: 2.1, 3.0 Apr 18, 2014
takluyver added a commit that referenced this issue May 7, 2014
Keeps track of the most recent request, so async output is still allowed

closes #5407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant