Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scp checking for existence of directories: directory names are incorrect #5417

Closed
myrtlecat opened this issue Mar 24, 2014 · 2 comments · Fixed by #5418
Closed

scp checking for existence of directories: directory names are incorrect #5417

myrtlecat opened this issue Mar 24, 2014 · 2 comments · Fixed by #5418
Milestone

Comments

@myrtlecat
Copy link

Commit d02d222 is supposed to ensure that SSHlaunchers check that destination directories exist when copying files between hosts (see issue #3411). However there is a bug where the hostname (or ip address) of the destination machine is included in the directory name by mistake.

The offending code is:

check_output(self.ssh_cmd + self.ssh_args + \
    [self.location, 'mkdir', '-p', '--', remote_dir]
)

The problem is that remote_dir includes the hostname (or ip) of the destination machine, so for example a directory that should be created on the destination machine at:

~/.ipython/profile_ssh/security

will instead be created at:

~/<DESTINATION HOSTNAME>/.ipython/profile_ssh/security
@minrk
Copy link
Member

minrk commented Mar 24, 2014

Thanks, should be fixed by #5418. Can you confirm?

@minrk minrk added this to the 2.0 milestone Mar 24, 2014
@myrtlecat
Copy link
Author

Wow, fast turnaround!

Yes, that should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants