Stretch keyboard shortcut dialog #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is no longer needed with `display: flex`
for stretching a dialog to fill the screen
|
Just out of curiosity, what problems did the |
|
it overrides the width on the modal dialog after applying .modal_stretch |
|
Ahh, sounds ugly. Anyways, 👍 from me. Code looks good and works on my machine. |
minrk
added a commit
that referenced
this pull request
Mar 31, 2014
Stretch keyboard shortcut dialog
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Stretch keyboard shortcut dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a
modal_stretchCSS class to fill the screen for large dialogs (e.g. keyboard shortcuts). This performs better on both large and small screens than regular dialogs with a fixed max-height.I had to remove an old
width: 100%workaround for Firefox that @jdfreder assured me is no longer needed with the newdisplay: flex.small screen:
large screen:
closes #5413.