Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bookmark -l" not working in ipython 2.0 #5676

Closed
thomas-haslwanter opened this issue Apr 19, 2014 · 1 comment · Fixed by #5677
Closed

"bookmark -l" not working in ipython 2.0 #5676

thomas-haslwanter opened this issue Apr 19, 2014 · 1 comment · Fixed by #5677
Labels
Milestone

Comments

@thomas-haslwanter
Copy link

On

C:\WinPython-64bit-3.3.3.3\python-3.3.3.amd64>python -c "import IPython; print(IPython.sys_info())"
{'commit_hash': 'd268878',
'commit_source': 'installation',
'default_encoding': 'cp850',
'ipython_path': 'C:\WinPython-64bit-3.3.3.3\python-3.3.3.amd64\lib\site-pac kages\IPython',
'ipython_version': '2.0.0',
'os_name': 'nt',
'platform': 'Windows-7-6.1.7601-SP1',
'sys_executable': 'C:\WinPython-64bit-3.3.3.3\python-3.3.3.amd64\python.exe'
,
'sys_platform': 'win32',
'sys_version': '3.3.3 (v3.3.3:c3896275c0f6, Nov 18 2013, 21:19:30) [MSC v.1600 64 bit (AMD64)]'}

the command
%bookmark -l

crashes, with the following message:

AttributeError Traceback (most recent call last)
in ()
----> 1 get_ipython().magic('bookmark -l')

C:\WinPython-64bit-3.3.3.3\python-3.3.3.amd64\lib\site-packages\IPython\core\interactiveshell.py in magic(self, arg_s)
2203 magic_name, _, magic_arg_s = arg_s.partition(' ')
2204 magic_name = magic_name.lstrip(prefilter.ESC_MAGIC)
-> 2205 return self.run_line_magic(magic_name, magic_arg_s)
2206
2207 #-------------------------------------------------------------------------

C:\WinPython-64bit-3.3.3.3\python-3.3.3.amd64\lib\site-packages\IPython\core\interactiveshell.py in run_line_magic(self, magic_name, line)
2124 kwargs['local_ns'] = sys._getframe(stack_depth).f_locals
2125 with self.builtin_trap:
-> 2126 result = fn(args,*kwargs)
2127 return result
2128

C:\WinPython-64bit-3.3.3.3\python-3.3.3.amd64\lib\site-packages\IPython\core\magics\osm.py in bookmark(self, parameter_s)

C:\WinPython-64bit-3.3.3.3\python-3.3.3.amd64\lib\site-packages\IPython\core\magic.py in (f, _a, *_k)
191 # but it's overkill for just that one bit of state.
192 def magic_deco(arg):
--> 193 call = lambda f, _a, *_k: f(_a, *_k)
194
195 if callable(arg):

C:\WinPython-64bit-3.3.3.3\python-3.3.3.amd64\lib\site-packages\IPython\core\magics\osm.py in bookmark(self, parameter_s)
665 elif 'l' in opts:
666 bks = bkms.keys()
--> 667 bks.sort()
668 if bks:
669 size = max(map(len, bks))

AttributeError: 'dict_keys' object has no attribute 'sort'

@takluyver takluyver added this to the 2.1 milestone Apr 19, 2014
takluyver added a commit to takluyver/ipython that referenced this issue Apr 19, 2014
Closes ipythongh-5676

Also add a simple test for %bookmark
@takluyver
Copy link
Member

Should be fixed in #5677.

takluyver added a commit that referenced this issue May 7, 2014
Closes gh-5676

Also add a simple test for %bookmark
takluyver added a commit that referenced this issue May 7, 2014
Closes gh-5676

Also add a simple test for %bookmark
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
Closes ipythongh-5676

Also add a simple test for %bookmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants