Sessionwork

[ellisonbg]

This refactors and adds tests to IPython.zmq.session.Session. The tests can be run with nosetests IPython.zmq.tests.test_session.

• Renamed the unpack_message method to unserialize.
• Removed msg_id and msg_type from the top-level message dict (put into headers) throughout the code base.
• Added tests.
• Updated the docstrings for Session.

[minrk]

One thing you might do, since now you are doing many nested dict requests that weren't there before, is add a few msg_id = msg['header']['msg_id'], so you aren't asking for an element of an element of a dict more than you need to.

[ellisonbg]

OK, I have done this in all of the cases where it helps.

On Thu, Jul 14, 2011 at 1:54 PM, minrk
reply@reply.github.com
wrote:

One thing you might do, since now you are doing many nested dict requests that weren't there before, is add a few msg_id = msg['header']['msg_id'], so you aren't asking for an element of an element of a dict more than you need to.

Reply to this email directly or view it on GitHub:
#579 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[ellisonbg]

This branch should not be merged until after the 0.11 release.

[ellisonbg]

@minrk: with 0.11 out, can you review this to make sure it is ready to go into master. The htmlnotebook branch is based on this and I would to have this merged so I can follow master again.

[minrk]

It hasn't changed since I last looked it over, and I just read it over again, so I think it should be fine. Merging this should probably trigger creating the 0.11 maintenance branch.