Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to embed local videos using html5 #5987

Closed
dawehner opened this issue Jun 14, 2014 · 4 comments
Closed

Allow to embed local videos using html5 #5987

dawehner opened this issue Jun 14, 2014 · 4 comments

Comments

@dawehner
Copy link
Contributor

As shown in http://nbviewer.ipython.org/github/ipython/ipython/blob/1.x/examples/notebooks/Part%205%20-%20Rich%20Display%20System.ipynb you can embed videos into ipython not only using Youtube or Vimeo but also local files.

Is there a reason why there is no simple way of an Video display which allows you to pass in the filepath?

@Carreau Carreau added this to the wishlist milestone Jun 14, 2014
@Carreau
Copy link
Member

Carreau commented Jun 14, 2014

I don't see any reason not to do that.
It might just blow up size of notebooks.

Tagging as quickfix, as this is probably easy to do. Thanks for the suggestion.

@dawehner
Copy link
Contributor Author

Cool, I always thought this just seems so obvious ...
You are right that this blows up the size of notebooks, but it is notally usable as long you are on your local system. This is problematic for nbviewer notebooks, sadly

#5992 is an initial version, feel free to comment

@mpenkov
Copy link
Contributor

mpenkov commented Sep 30, 2018

It looks like #5992 got merged, so perhaps this issue should be marked as completed?

@Carreau
Copy link
Member

Carreau commented Sep 30, 2018

Sure, thanks.

You should be able to close it by mentioning our helper bot as follow:

@meeseeksdev[bot] close

@lumberbot-app lumberbot-app bot closed this as completed Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants