"-datetime.timedelt" not completed

[lebigot]

After the necessary import datetime, completing -datetime.timedelt with TAB does not work. Doing the same with datetime.timedelt works as expected.

Python 2.7.8 (default, Jul 13 2014, 17:11:32)
IPython 2.1.0

[Carreau]

Pep8 ! 1-datetime.timedelt<tab> does not work, but 1 - datetime.timedelt<tab> does.
We might try to fix it but it's probably difficult as ot require to make sens of unfinished python code. It is not that obvious to do, as things might be in currently-not-complete-strings-that-are-in-fact-filename so were to split is not obvious.

[takluyver]

Was this in the notebook, the terminal or the Qt console? Tab completion works different ways in different environments.

[Carreau]

I tested on pure ipython shell.

[lebigot]

The problem is present in the terminal.

Note that PEP 8 does not apply here ("If operators with different priorities are used, consider adding whitespace"). Plus, I was not doing 1-datetime… but simply -datetime…. :)

Also, one of the uses of ipython is to perform calculations quickly, so here, I would "use my own judgment" (PEP 8) and would not see any reasons to put spaces around operations, usually (in a terminal—a notebook would be different, since it is for others to read, maybe).

Finally, I'm not sure I get the "might be a filename" parsing argument either: why would 2+date<TAB> complete correctly but not 2-date<TAB>? there is something special and unexpected happening when completing a name preceded by "-".

[Carreau]

The pep-8 part was a joke,

And the comment about filename ment that there is probably a reason why it treats - differently. This reason might not be anymore.

Thinking about it a bit more, the only case where I see a tokenization difference for +- are magics that uses arguments. Thus the - might be treated as part of the valid char for a token whereas + is not.

Note that the completer messaging spec has change recently so it might help fixing that at some point. I just wouldn't put too much hope into the fact that this is a simple fix that new to treat - and + equally.

Envoyé de mon iPhone

Le 23 juil. 2014 à 12:24, "Eric O. LEBIGOT (EOL)" notifications@github.com a écrit :

The problem is present in the terminal.

Note that PEP 8 does not apply here ("If operators with different priorities are used, consider adding whitespace").

Also, one of the uses of ipython is to perform calculations quickly, so here, I would "use my own judgment" (PEP 8) and would not see any reasons to put spaces (in a terminal—a notebook would be different, since it is for others to read, maybe).

Finally, I'm not sure I get the "might be a filename" parsing argument either: why would 2+date complete correctly but not "2-date"? there is something special and unexpected happening when completing a name preceded by "-".

—
Reply to this email directly or view it on GitHub.

[lebigot]

Hmm. Good idea. Now, I never use magic commands with arguments, but I do a lot of subtractions, and not having completion in this case is a real limitation… :)

[takluyver]

Yes, we explicitly remove - from the list of things readline treats as delimiters, probably so that it's possible to complete things like --foo. Also, I guess dashes are more common in filenames than + signs.

We might be able to improve this when we get to reworking the completions machinery, but that code is pretty thorny.

[Carreau]

This will be fixed by #10182

[Carreau]

closed by #10182