import pexpect from IPython.external in irunner #628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can just import from IPython.external without the try/except. The packages in IPython.external already try the system version first, then fall back on the bundled version |
|
Done, thanks @minrk! |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
This makes irunner safe if the user doesn't have a system install of pexpect. Closes ipythongh-628.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial fix, but since it's technically a code change, I'm making it a PR. irunner unconditionally imports pexpect, rather than falling back on IPython.external.pexpect, so it won't work in cases where it should. I only noticed because I just cleaned out my whole environment and hadn't reinstalled pexpect yet. You can't even build the docs if you don't have pexpect, because the import fails.