print is a function, this allows to properly exit ipython #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under Fedora 15 a single print seems to be not allowed in ipython, so we need to use print as a function here. After this commit, there is a proper newline on exiting with CTRL+d Closes ipythongh-637.
|
This shouldn't be Fedora-specific. The I think the reason I never noticed the absence of the newline is that I actually like it without the newline better, but that's clearly not the intent of the code. Thanks! |
|
I've made the changes (including the extra one) in the what's new branch, so I'm closing it here manually (commit credit was left as Tom's). Thanks, @tomspur! |
fperez
pushed a commit
to fperez/ipython
that referenced
this pull request
Jul 30, 2011
These were causing a missing newline on exit. Closes ipythongh-637, slightly modified from the original version, as there was one more print elsewhere in the file.
fperez
pushed a commit
to fperez/ipython
that referenced
this pull request
Jul 30, 2011
These were causing a missing newline on exit. Closes ipythongh-637, slightly modified from the original version, as there was one more print elsewhere in the file.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
These were causing a missing newline on exit. Closes ipythongh-637, slightly modified from the original version, as there was one more print elsewhere in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Fedora 15 a single print seems to be not allowed in ipython,
so we need to use print as a function here.
After this commit, there is a proper newline on exiting with CTRL+d