HistoryManager.get_session_info() #679
Conversation
Also set detect_types flags on the connection, so timestamps are retrieved as datetime objects. Associated type checking test included.
|
This seems sensible. I'm planning, when I have time, to pull out the methods for reading history into a |
| @@ -170,7 +171,7 @@ def default_config(): | |||
| config.TerminalInteractiveShell.colors = 'NoColor' | |||
| config.TerminalTerminalInteractiveShell.term_title = False, | |||
| config.TerminalInteractiveShell.autocall = 0 | |||
| config.HistoryManager.hist_file = u'test_hist.sqlite' | |||
| config.HistoryManager.hist_file = os.path.join(tempfile.mkdtemp(), u'test_hist.sqlite') | |||
There was a problem hiding this comment.
This file should be added to the list of files we delete on exit, so that we clean up after ourselves. But instead of making a temp directory, let's simply make a temp file with the suffix 'test_hist.sqlite'. Then the cleanup is simply a matter of removing the file on exit, which can be done by registering it with the ipython instance's .tempfiles attribute, that all get deleted at interpeter shutdown time.
* end_history_session moved before tempfile cleanup in shell.atexit_operations, to prevent access to file after deletion
Add method to HistoryManager for fetching session timestamps, etc. The method is: HistoryManager.get_session_info() Also sets detect_types flags on the db connection, so timestamps are retrieved as datetime objects. The test history file has been moved to a tempdir, so that we don't get test_hist.sqlite files all over the filesystem when running the test suite.
Add method to HistoryManager for fetching session timestamps, etc. The method is: HistoryManager.get_session_info() Also sets detect_types flags on the db connection, so timestamps are retrieved as datetime objects. The test history file has been moved to a tempdir, so that we don't get test_hist.sqlite files all over the filesystem when running the test suite.
add simple get_session_info method to HistoryManager for fetching session timestamps, etc.
Also sets detect_types flags on the db connection, so timestamps are retrieved as datetime objects.
The test history file has been moved to a tempdir, so that we don't get test_hist.sqlite files all over the filesystem when running the test suite.