Protect ipkernel from bad messages #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invalid or unauthorized messages no longer crash the kernel.
also change message for unsigned messages when digest expected
fperez
added a commit
that referenced
this pull request
Aug 16, 2011
Protect ipkernel from bad messages: now the kernel logs bad messages as errors instead of crashing.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Protect ipkernel from bad messages: now the kernel logs bad messages as errors instead of crashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit protects the IPython kernel from invalid or unauthorized messages.
Previously, sending garbage to the kernel would crash it, as would sending unauthorized messages if HMAC signatures were enabled.
See #688