PyPy compatibility #722
Merged
PyPy compatibility #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e modified version needed for PyPy's readline to work.
|
The shell is now working OK with PyPy's readline. Haven't tried to make all the tests pass. |
|
Do we want to wait for further PyPy compatibility, or should we just merge this now? It seems fine as-is to me. |
|
I'm happy to merge this now. We can always do more later if we need to. I just made a PR to check that it was OK to store the original |
|
Yes, I think this makes sense. I think it's actually better, because IPython should use the raw_input of the environment into which it is launched, not that of the top of the first file to import it. |
|
OK, great. I've merged it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, this just gets it to start. It still has trouble with readline, and there a lot of test failures - a combination of nose, the limitations of PyPy's numpy module, small differences in output for doctests, and unicode.
Will liaise with PyPy developers - first off, about readline, because without tab completion, one of the big advantages of IPython is missing.
Closes gh-719