New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: test runner fails if repo path contains spaces #760
Comments
Pull request #761 |
Since PR #761 was closed, this one remains open. Retargeting for 0.13... |
Confirming that this is not yet resolved, but will be fixed by #1888 (which is tagged for 0.14). |
OK, let's retarget the bug for 0.14, then. Thanks, @jdmarch for the info. |
@fperez - To be clearer: This would be provisionally fixed by workaround #2016 which I think is ok for 0.13. @jstenar - I suggest that our Windows test machines should locate the repo in a directory whose path contains spaces, even if this is unconventional for Win7, because it is a stronger test which will catch issues that normally would only appear on a typical WinXP setup, not a typical Win7 setup. If/when #2016 is merged, this should become feasible. If we did this, then we could consider this issue closed because our autotesting would catch it if it ever re-emerged. |
Since #2016 has gone in, it seems to me that this can now be closed, right? I agree with the recommendation of setting up Windows test repos in directories with spaces, but that's not something we should keep an issue open for, since it's independent of our codebase. Or is there anything else we should leave this open for? |
I still see this problem (or at least a very similar one)
I'm working on a fix for this and a unicode problem in iptest. |
PR #2046 fixes the problems I showed above as well as the unicode problem when running iptest in a path with unicode characters. I ran tests on windows under both Python 2.7 and Python 3.2 without errors. |
iptest unicode - fix space in path issue for iptest when using --with-xunit - fix unicode issue in path for iptest closes ipython#760
It is common in Windows XP installations for the home dir to be in "Documents and Settings". If the ipython repo is in the home dir, then the test runner will fail.
The text was updated successfully, but these errors were encountered: