Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: test runner fails if repo path contains spaces #760

Closed
jdmarch opened this issue Sep 4, 2011 · 8 comments
Closed

Windows: test runner fails if repo path contains spaces #760

jdmarch opened this issue Sep 4, 2011 · 8 comments

Comments

@jdmarch
Copy link

jdmarch commented Sep 4, 2011

It is common in Windows XP installations for the home dir to be in "Documents and Settings". If the ipython repo is in the home dir, then the test runner will fail.

@jdmarch
Copy link
Author

jdmarch commented Sep 4, 2011

Pull request #761

@fperez
Copy link
Member

fperez commented Dec 17, 2011

Since PR #761 was closed, this one remains open. Retargeting for 0.13...

@jdmarch
Copy link
Author

jdmarch commented Jun 23, 2012

Confirming that this is not yet resolved, but will be fixed by #1888 (which is tagged for 0.14).

@fperez
Copy link
Member

fperez commented Jun 24, 2012

OK, let's retarget the bug for 0.14, then. Thanks, @jdmarch for the info.

@jdmarch
Copy link
Author

jdmarch commented Jun 24, 2012

@fperez - To be clearer: This would be provisionally fixed by workaround #2016 which I think is ok for 0.13.

@jstenar - I suggest that our Windows test machines should locate the repo in a directory whose path contains spaces, even if this is unconventional for Win7, because it is a stronger test which will catch issues that normally would only appear on a typical WinXP setup, not a typical Win7 setup. If/when #2016 is merged, this should become feasible.

If we did this, then we could consider this issue closed because our autotesting would catch it if it ever re-emerged.

@fperez
Copy link
Member

fperez commented Jun 25, 2012

Since #2016 has gone in, it seems to me that this can now be closed, right? I agree with the recommendation of setting up Windows test repos in directories with spaces, but that's not something we should keep an issue open for, since it's independent of our codebase. Or is there anything else we should leave this open for?

@jdmarch jdmarch closed this as completed Jun 25, 2012
@jstenar
Copy link
Member

jstenar commented Jun 27, 2012

I still see this problem (or at least a very similar one)

(Py27) C:\python\ipydevel\VENV\a a> iptest --with-xunit
**********************************************************************
IPython test group: IPython.config
WARNING: Excluding nonexistent file: 'IPython\\\\testing\\\\plugin\\\\test_exampleip'
WARNING: Excluding nonexistent file: 'IPython\\\\scripts\\\\irunner'
..............................................E
======================================================================
ERROR: Failure: OSError (No such file c:\users\jstenar\appdata\local\temp\a\IPython.config.xunit.xml)

I'm working on a fix for this and a unicode problem in iptest.

@jstenar jstenar reopened this Jun 27, 2012
@jstenar
Copy link
Member

jstenar commented Jun 27, 2012

PR #2046 fixes the problems I showed above as well as the unicode problem when running iptest in a path with unicode characters. I ran tests on windows under both Python 2.7 and Python 3.2 without errors.

@minrk minrk closed this as completed in bb4488a Jun 27, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this issue Nov 3, 2014
iptest unicode

- fix space in path issue for iptest when using --with-xunit
- fix unicode issue in path for iptest

closes ipython#760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants