You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is related to #7242, but not quite fixed by that PR...
On Chrome on Linux, if I set the Consolas font to being my monospaced font, when running mc (Midnight Commander) in the in-notebook terminal, the computation of the column width must be wrong, b/c the page misrenders:
This is even more evident when an error box is drawn:
Checking the value of Terminal.brokenBold in the JS Console returns true with Consolas. Yet, the fix in #7242 isn't helping here.
For reference, switching to another monospaced font, such as DejaVu Sans Mono, fixes the problem. So at least there's a workaround.
But even if the bug is in Consolas, it would be nice if we could make it work correctly (if viable). Regular terminal emulators don't exhibit this behavior. In as much as possible, we want our terminal to match a 'real' terminal 100%.
Marking this for 3.1, as it's fairly obscure and there's an easy workaround for now.
The text was updated successfully, but these errors were encountered:
I guess 'real' terminal emulators draw each character at a calculated position. As @Carreau mentioned on gitter, doing that in termjs would involve wrapping each character in its own div.
Shouldn't we file this against term.js? It seems like setting a bad precedent to file bugs in termjs on IPython.
Certainly! I wasn't completely sure where the bug lied, which is why I filed it here.
You understand the details better (having actually worked with term.js). Feel free to close it here and reopen it on term.js. That way it's documented for us, even if we can't actually do anything about it.
As far as I'm concerned, all the rendering and interaction with the terminal is done by term.js. We just put it on a page with a bit of CSS, and pass messages between it and a websocket.
This is related to #7242, but not quite fixed by that PR...
On Chrome on Linux, if I set the Consolas font to being my monospaced font, when running mc (Midnight Commander) in the in-notebook terminal, the computation of the column width must be wrong, b/c the page misrenders:
This is even more evident when an error box is drawn:
Checking the value of
Terminal.brokenBold
in the JS Console returnstrue
with Consolas. Yet, the fix in #7242 isn't helping here.For reference, switching to another monospaced font, such as DejaVu Sans Mono, fixes the problem. So at least there's a workaround.
But even if the bug is in Consolas, it would be nice if we could make it work correctly (if viable). Regular terminal emulators don't exhibit this behavior. In as much as possible, we want our terminal to match a 'real' terminal 100%.
Marking this for 3.1, as it's fairly obscure and there's an easy workaround for now.
The text was updated successfully, but these errors were encountered: