Skip to content
This repository

The latest ipython branch doesn't work in Chrome #934

Closed
certik opened this Issue October 26, 2011 · 10 comments

3 participants

Ondřej Čertík Min RK Fernando Perez
Ondřej Čertík

It works great in Firefox. I don't have time currently to debug this, but in Chrome, it doesn't show any cells if I create a new notebook. My ipython master is a3c02d8.

Fernando Perez
Owner

What version of Chrome and Tornado are you using? Unfortunately, a few days ago in their dev channel, chrome changed their websocket protocol identifier and broke with released tornado. Major PITA for us...

Min RK
Owner

Yes, and tornado master has been updated to work.

We really need to draw a message on the error (426) that unsupported websockets causes.

Fernando Perez
Owner

Marking for 0.12 so at least we provide a meaningful error instead of the blank stare of death :)

Ondřej Čertík

I use the latest tornado, and Chrome 15.0.874.102. Definitely, some useful error message is necessary.

Fernando Perez
Owner

BTW, this is the tornado commit that fixed the problem for them. I talked to Brian also about this, and I think the most sensible solution for our users is to apply that commit as a tornado monkeypatch for now. I'm going to submit a PR with the monkeypatch just now so that our regular users don't have to fight too much with this for now.

Fernando Perez
Owner

PR opened at #948 to take care of the tornado part. We'll close this once we also have a proper error message.

Min RK
Owner

closed by merge of #948

Min RK minrk closed this October 30, 2011
Ondřej Čertík

I confirmed that this fixes it for me. I am closing the issue.

Fernando Perez
Owner

Nobody actually read my note above, did you ? :)

I deliberately did not close this issue until we also had a proper error message for the lack of websocket connections, though in all fairness that's a slightly different problem. I was just trying to keep things simple by having only open open issue around the whole problem.

Opened #952 then...

Ondřej Čertík

I was thinking about this, but then concluded that this issue really is fixed, and the warning is a different issue (but I should have opened the new issue for it), and then hit "comment & close", and then I noticed, that Min has already closed it in the meantime.

Thanks for fixing it so fast! Everything works excellent for me again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.