allow change of png DPI in inline backend #957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves setting the DPI to the rcParams initialization, so that it can be changed later by the user, setting `rcParams['savefig.figsize']`. DPI has no effect on SVG figures, so any other value will result in mismatch between svg and png figures.
|
Great, thanks! Rebased to prevent recursive merge on a single commit, pushed as 16e1771. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves setting the DPI to the rcParams initialization,
so that it can be changed later by the user, setting
rcParams['savefig.figsize'].DPI has no effect on SVG figures, so any other value will result in
mismatch between svg and png figures. There is already a mismatch in the notebook, where 72 is not the right answer.