Getting started on what's new #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| except AttributeError, err: | ||
| raise ValueError('github_project_url configuration value is not set (%s)' % str(err)) | ||
| # | ||
| slash = '/' if base[-1] != '/' else '' |
There was a problem hiding this comment.
Isn't this redundant with the check a few lines above?
There was a problem hiding this comment.
Indeed it is - I added the endswith check, because I wasn't fond of how upstream did it, but then never removed the previous one. I'll remove it.
|
Assuming the Sphinx extension is working, I think you can go ahead with this. |
adapted from Doug Hellmann's bitbucket extension.
minrk
added a commit
that referenced
this pull request
Nov 9, 2011
Getting started on What's New for 0.12, and adding github sphinx extension, for easy links to GitHub issues, pull requests, etc.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Getting started on What's New for 0.12, and adding github sphinx extension, for easy links to GitHub issues, pull requests, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some notes on significant changes in 0.12 to the development whatsnew doc.
Doing as a PR rather than pushing directly, because I also added a github sphinx extension, adapted from this bitbucket one.