fix arguments for commands in _process_posix #989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quotations marks could trivially break the command parsing. This has been fixed by using the `args` kwarg, rather than trying to stuff it all into one string. previously-failing tests added
|
Great, thanks. Usual rebase/merge dance now. |
|
Merged as 3830949 |
|
It's possible the new tests reveal similar bugs on Windows, so I will test that when I get home, and push directly if fixes are obvious. |
|
Great, thanks. |
|
These tests passed just fine, but I found a couple other tiny test fixes from the last couple weeks. |
mdboom
pushed a commit
to mdboom/ipython
that referenced
this pull request
Dec 2, 2011
quotations marks could trivially break the command parsing. This has been fixed by using the `args` kwarg, rather than trying to stuff it all into one string. previously-failing tests added Closes ipythongh-989.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
quotations marks could trivially break the command parsing. This has been fixed by using the `args` kwarg, rather than trying to stuff it all into one string. previously-failing tests added Closes ipythongh-989.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quotations marks could trivially break the command parsing. This has been
fixed by using the
argskwarg, rather than trying to stuff it all intoone string.
previously-failing tests added
as discussed in #514