add Integer traitlet #996
Closed
add Integer traitlet #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most int traits are now Integers
Integer differs from Long only in that small `long`s are cast to `int`, rather than
all `int`s being cast to `long`:
Integer(4L) => 4
Long(4) => 4L
closes ipythongh-942
|
Looks OK to me. I haven't tested in Python 3, but from what I know 2to3 does, it should work (it just becomes effectively the same as Int). |
|
The Integer traitlet is defined inside the same |
|
Oh yes, I'd missed that. |
|
Looks good. Rebased and merged in 293d3ee. Thanks! |
stefanv
pushed a commit
to stefanv/ipython
that referenced
this pull request
Nov 30, 2011
Most int traits are now Integers
Integer differs from Long only in that small `long`s are cast to `int`, rather than
all `int`s being cast to `long`:
Integer(4L) => 4
Long(4) => 4L
closes ipythongh-942, closes ipythongh-996.
Rebased to avoid recursive merge for just one commit.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Most int traits are now Integers
Integer differs from Long only in that small `long`s are cast to `int`, rather than
all `int`s being cast to `long`:
Integer(4L) => 4
Long(4) => 4L
closes ipythongh-942, closes ipythongh-996.
Rebased to avoid recursive merge for just one commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most
Inttraits are nowIntegersInteger differs from Long only in that small
longs are cast toint, rather thanall
ints being cast tolong:closes gh-942