-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #11309 (handle quotes in magics arguments) #11330
Conversation
handles spaces or quotes in filename param
@hongshaoyang have you had a chance to look into the CI check failures you're getting? |
hi @mUtterberg , yes i have. changed my approach to use regex. CI checks work now. |
Awesome! Do you think you could write a test for this issue in core/tests/test_completion? |
done! i've written a test in core/tests/test_magic instead because thats where all the |
Thanks, that looks good to me as well. Merging. |
fixes #11309 - handles quotes in filename param