Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11309 (handle quotes in magics arguments) #11330

Merged
merged 6 commits into from Oct 13, 2018

Conversation

@hongshaoyang
Copy link
Contributor

commented Sep 25, 2018

fixes #11309 - handles quotes in filename param

hongshaoyang added some commits Sep 25, 2018

Fix #11309
handles spaces or quotes in filename param

@Carreau Carreau changed the title Fix #11309 Fix #11309 (handle quotes in magics arguments) Sep 25, 2018

@mUtterberg

This comment has been minimized.

Copy link

commented Oct 9, 2018

@hongshaoyang have you had a chance to look into the CI check failures you're getting?

@hongshaoyang

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2018

hi @mUtterberg , yes i have. changed my approach to use regex. CI checks work now.

@minrk

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

Awesome! Do you think you could write a test for this issue in core/tests/test_completion?

hongshaoyang added some commits Oct 12, 2018

@hongshaoyang

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2018

done! i've written a test in core/tests/test_magic instead because thats where all the %%writefile tests are. also modified test_magic.py to use %%writefile instead of %%file in PR #11387

@Carreau Carreau added this to the 7.1 milestone Oct 13, 2018

@Carreau

This comment has been minimized.

Copy link
Member

commented Oct 13, 2018

Thanks, that looks good to me as well.

Merging.

@Carreau Carreau merged commit 2f25f7d into ipython:master Oct 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hongshaoyang hongshaoyang deleted the hongshaoyang:patch-1 branch Oct 14, 2018

@takluyver takluyver referenced this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.