Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom completions to define their own ordering. #11855

Merged
merged 1 commit into from Nov 17, 2019

Conversation

tonyfast
Copy link
Contributor

@tonyfast tonyfast commented Aug 14, 2019

The completer by default orders all of the matches.

Screen Shot 2019-08-14 at 5 24 18 PM

An author may desire to present an unordered set of completions. This pull requests modifies the completer to return custom ordered completions, sorted results may be explicitly defined by a completer function.

@Carreau Carreau added this to the 7.10 milestone Nov 17, 2019
@Carreau
Copy link
Member

@Carreau Carreau commented Nov 17, 2019

Thanks Tony,

Apologies if this took a lot of time to review. That looks good.

<3

@Carreau Carreau merged commit f6b22cc into ipython:master Nov 17, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants