Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static message instead of function call to prevent shell slowdown #11933

Merged
merged 3 commits into from Nov 13, 2019

Conversation

@gerrit8143
Copy link
Contributor

gerrit8143 commented Nov 1, 2019

@Carreau

This comment has been minimized.

Copy link
Member

Carreau commented Nov 3, 2019

Hum, unlike what I said in #11496 his actually breaks the prompt when using vi mode for example.
Vi mode ($ ipython --TerminalInteractiveShell.editing_mode=vi) shows in the prompt wether we are in insert or normal mode.

So we'll have to a be a bit smarter as to wether we compute this once, or regularly.

@Carreau

This comment has been minimized.

Copy link
Member

Carreau commented Nov 3, 2019

I've push some changes on your brnach that shoudl fix the high number of call with the default mode, but keep the changing prompt when using vi keybinding. Let me know what you think.

@gerrit8143

This comment has been minimized.

Copy link
Contributor Author

gerrit8143 commented Nov 3, 2019

looks good to me, so let's do it that way.

@Carreau

This comment has been minimized.

Copy link
Member

Carreau commented Nov 11, 2019

looks good to me, so let's do it that way.

Thanks, I'll update the whats new note when I have time and then merge.
Should be released by end of month.

@Carreau Carreau added this to the 7.10 milestone Nov 12, 2019
@Carreau Carreau merged commit cc1abb8 into ipython:master Nov 13, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.