Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: wx inputhook #12375

Merged
merged 1 commit into from Jun 8, 2020
Merged

BF: wx inputhook #12375

merged 1 commit into from Jun 8, 2020

Conversation

pauldmccarthy
Copy link
Contributor

This PR contains a small, obvious bug fix to the IPython.terminal.pt_inputhooks.wx module. The bug does not cause any adverse behaviour when using prompt_toolkit < 3, but interferes with GUI integration when using prompt_toolkit >= 3.

…get called

after ExitMainLoop has been called
@Carreau Carreau added this to the 7.16 milestone Jun 8, 2020
@Carreau Carreau merged commit a80908b into ipython:master Jun 8, 2020
@Carreau
Copy link
Member

Carreau commented Jun 8, 2020

@meeseeskdev backport to 7.x

@ipython ipython deleted a comment from lumberbot-app bot Jun 8, 2020
@Carreau
Copy link
Member

Carreau commented Jun 8, 2020

@meeseeskdev backport to 7.x

@Carreau
Copy link
Member

Carreau commented Jun 8, 2020

@meeseeskdev say hi.

@Carreau Carreau added the Still Needs Manual Backport Added My MrMeeseeks when a backport fails. Help by backporting it, solving conflicts, send PR. label Jun 8, 2020
@Carreau
Copy link
Member

Carreau commented Jun 8, 2020

Ok, the bot is down for whatever reason sorry for the spam.

@Carreau
Copy link
Member

Carreau commented Jun 8, 2020

@meeseeksdev say hello

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Jun 8, 2020

hello

@Carreau
Copy link
Member

Carreau commented Jun 8, 2020

@meeseeksdev backport to 7.x

meeseeksmachine pushed a commit to meeseeksmachine/ipython that referenced this pull request Jun 8, 2020
@Carreau Carreau removed the Still Needs Manual Backport Added My MrMeeseeks when a backport fails. Help by backporting it, solving conflicts, send PR. label Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants