Don't ask for confirmation when stdin isn't available #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. Let's wait a day or two so others have a chance to also look at it, but as far as I'm concerned, it can be merged. |
|
looks good to me as well, i sent @takluyver a PR with an update to the docs, and to have the "Overwriting file." message be printed to all clients, not just the notebook interface |
Relevant docstring changes.
|
@ivanov, thanks for the improvements! This looks good to me and the tests pass, as well as working OK in interactive testing. Merging now. |
fperez
added a commit
that referenced
this pull request
Jan 20, 2012
Don't ask for confirmation when stdin isn't available for actions like %reset or %history -f. Since the change is applied only on the Stdin error, once the notebook gets a stdin, it will naturally work.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Don't ask for confirmation when stdin isn't available for actions like %reset or %history -f. Since the change is applied only on the Stdin error, once the notebook gets a stdin, it will naturally work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the notebook, we can't ask the user to confirm actions with a y/n prompt, because stdin doesn't work. But they probably didn't type %reset by accident, so we may as well go ahead and do it.
Points to consider:
resetvariable in scope, and try to examine its value? One way round this would be to drop reset in the builtins (as an explanatory string), forcing them to explicitly type %reset. But I suspect this is overkill.Closes gh-1268