print_figure return base64 str instead of bytes #13162
Merged
+54
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made it backward-compatible by leaving the default value as False in case there are any other callers of |
minrk
force-pushed
the
base64-mpl-figures
branch
from
36d2e75
to
e40ec9f
Compare
sending bytes relies on serializer's `default` functionality, where we can just send the right thing here this used to be ambiguous on Python 2, but not anymore
minrk
force-pushed
the
base64-mpl-figures
branch
from
e40ec9f
to
4a2e85f
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Sep 30, 2021
Carreau
added a commit
that referenced
this pull request
Oct 3, 2021
…162-on-7.x Backport PR #13162 on branch 7.x (print_figure return base64 str instead of bytes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sending bytes relies on serializer's
defaultfunctionality, where we can just send the right thing here. This used to be ambiguous on Python 2 whenstr is bytes, but not anymore.This should also avoid jupyter/jupyter_client#702