Remove set-next input when triggering help. #13625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
force-pushed
the
nosni
branch
2 times, most recently
from
e9de4cc
to
6b06908
Compare
This was a long standing feature from when the main way to edit code was readline. Now that we have proper history and editing frontend, including prompt toolkit this is not necessary, especially since it creates issue like in JupyterLab. Should close ipython#13602
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
lumberbot-app
bot
added
the
Still Needs Manual Backport
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
Apr 7, 2022
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
Apr 7, 2022
Carreau
added a commit
that referenced
this pull request
Apr 27, 2022
Backport PR #13625: Remove set-next input when triggering help.
Carreau
removed
the
Still Needs Manual Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a long standing feature from when the main way to edit code was
readline. Now that we have proper history and editing frontend,
including prompt toolkit this is not necessary, especially since it
creates issue like in JupyterLab.
Should close #13602