Fix some minor color/style config issues in the qtconsole #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously used 'r' for all 3 values
otherwise a TypeError is raised in str.translate, since unicode.translate takes a dict, while str.translate takes a bytestring
… exists also ensure _control attributes start out as None, rather than undefined
* setting IPythonWidget.style_sheet is no longer clobbered by other config or defaults. * tabs other than the first get configured colors
|
I don't have Qt installed on this system, but the code looks good. |
minrk
added a commit
that referenced
this pull request
Feb 8, 2012
Fix some minor color/style config issues in the qtconsole The tabbed code changed a few things about loading styles and stylesheets in the qtconsole, which this resolves, among a couple other small color-related issues: * tabs other than the first get colors * IPythonWidget.style_sheet configurable is not clobbered by defaults * style_sheet configurable would cause a crash, because _style_sheet_changed could be called before _control existed * fix str->unicode token preventing stylesheets without syntax highlighting from working * fix typo in the function used to detect whether a bgcolor is dark or light
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix some minor color/style config issues in the qtconsole The tabbed code changed a few things about loading styles and stylesheets in the qtconsole, which this resolves, among a couple other small color-related issues: * tabs other than the first get colors * IPythonWidget.style_sheet configurable is not clobbered by defaults * style_sheet configurable would cause a crash, because _style_sheet_changed could be called before _control existed * fix str->unicode token preventing stylesheets without syntax highlighting from working * fix typo in the function used to detect whether a bgcolor is dark or light
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tabbed code changed a few things about loading styles and stylesheets in the qtconsole, which this resolves, among a couple other small color-related issues: