remove calls to meaningless ZMQStream.on_err #1374

Merged
merged 1 commit into from Feb 6, 2012

Conversation

Projects
None yet
2 participants
@minrk
Owner

minrk commented Feb 4, 2012

The event meant to trigger this callback can never occur, and the method will be deprecated and eventually removed from PyZMQ.

Also removes commented-out original implementation of Kernel.start.

remove calls to meaningless ZMQStream.on_err
The event meant to trigger this callback can never be called, and
the method will be deprecated and eventually removed from PyZMQ.
@ellisonbg

This comment has been minimized.

Show comment Hide comment
@ellisonbg

ellisonbg Feb 6, 2012

Owner

This seems trivial, going to merge.

Owner

ellisonbg commented Feb 6, 2012

This seems trivial, going to merge.

ellisonbg added a commit that referenced this pull request Feb 6, 2012

Merge pull request #1374 from minrk/on_err
remove calls to meaningless ZMQStream.on_err

@ellisonbg ellisonbg merged commit 64c7b29 into ipython:master Feb 6, 2012

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #1374 from minrk/on_err
remove calls to meaningless ZMQStream.on_err
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment