Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fall back to native when printing an ExceptionGroup #14108

Merged
merged 7 commits into from Jul 13, 2023

Conversation

jakkdl
Copy link
Contributor

@jakkdl jakkdl commented Jun 30, 2023

Fixes #13753

I started looking into delving deeper into ultratb to add support for Exception Groups, but felt that this would be enough of an improvement over the status quo that it'd probably be worth implementing on it's own.
I also looked quite a bit at ipyparallel's CompositeError https://github.com/ipython/ipyparallel/blob/main/ipyparallel/error.py#L169, which seems like the equivalent of exception groups.

Remaining TODO:

  • add tests
  • add documentation

Will go ahead with those if the basic approach is deemed acceptable

@jakkdl jakkdl force-pushed the fallback_display_exceptiongroup branch from 06e2175 to 46e4d49 Compare July 10, 2023 11:04
@jakkdl jakkdl force-pushed the fallback_display_exceptiongroup branch from 46e4d49 to 92b86a7 Compare July 10, 2023 11:07
@jakkdl jakkdl marked this pull request as ready for review July 10, 2023 13:50
@jakkdl
Copy link
Contributor Author

jakkdl commented Jul 10, 2023

I have no idea why the Run Downstream tests are failing, or if it's a problem in the PR. But otherwise everything passes, and docs & tests are written.

@Carreau would you mind reviewing?

@Carreau
Copy link
Member

Carreau commented Jul 13, 2023

Apologies for the delay in reviewing I don't have much time on IPython.

Don't worry about the downstream failure.

@Carreau Carreau merged commit 87828d3 into ipython:main Jul 13, 2023
17 of 19 checks passed
@Carreau Carreau added this to the 8.15 milestone Jul 13, 2023
@jakkdl
Copy link
Contributor Author

jakkdl commented Jul 13, 2023

No worries! I noticed you said the same in the other PRs so realized I should just go full steam ahead and implement the full PR so you only needed a single review pass :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ultratb hides the contents of ExceptionGroup errors
2 participants