New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_home_dir expands symlinks, adjust test accordingly #1413

Merged
merged 1 commit into from Feb 21, 2012

Conversation

Projects
None yet
2 participants
@minrk
Member

minrk commented Feb 18, 2012

closes #1408

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Feb 19, 2012

Member

This changes the test to match get_home_dir's behavior. It is possible that some consider the change in get_home_dir's behavior to be undesirable, which can be discussed further in #1402.

Member

minrk commented Feb 19, 2012

This changes the test to match get_home_dir's behavior. It is possible that some consider the change in get_home_dir's behavior to be undesirable, which can be discussed further in #1402.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Feb 21, 2012

Member

I think it makes sense for get_home_dir to return the real path, so I think you can merge this fix.

Member

takluyver commented Feb 21, 2012

I think it makes sense for get_home_dir to return the real path, so I think you can merge this fix.

minrk added a commit that referenced this pull request Feb 21, 2012

Merge pull request #1413 from minrk/realpath
get_home_dir expands symlinks, adjust test accordingly

@minrk minrk merged commit 0ceba04 into ipython:master Feb 21, 2012

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #1413 from minrk/realpath
get_home_dir expands symlinks, adjust test accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment