Support completion based on type annotations of calls #14185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
force-pushed
the
type-inferrence
branch
from
e431b81
to
3d06e9f
Compare
Carreau
approved these changes
Oct 1, 2023
12 tasks
Carreau
added a commit
that referenced
this pull request
Feb 27, 2024
Addresses the issue of non-jedi completer not picking type annotations for `__init__()` brought up in #14336  Follow-up to #14185 Supports: - [x] `Annotated` - [x] `AnyStr` - [x] `Literal` - [x] `LiteralString` - [x] `NewType` - [x] `Optional` - [x] `Protocol` - [x] `Self` - [x] `TypeAliasType` (`type` keyword in Python 3.12+) - [x] `TypedDict` - [x] `TypeGuard` - [x] `Union` Limitations: - no type narrowing: ambiguous return types from `Union`, and `Optional` will always return all possible values - generics (`TypeVar` and `Generic`) are not support (except for `AnyStr`) - old style `TypeAlias` (deprecated in Python 3.12) is not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #14184 when
%config IPCompleter.use_jedi=Falseis used: