Fix memory leak in Qt event loop integration (#14240) #14251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: ipython#14240 - the QEventLoop, `event_loop`, is not deleted when exiting the scope as passing `app` to the constructor parents the object to `app`. This creates a memory leak as QEventLoop objects are being accumulated. - issue reported by and fix suggested by @pag
ccordoba12
reviewed
Nov 24, 2023
There was a problem hiding this comment.
@hperrey, a small suggestion for you, then it should be good to be merged.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
|
Thanks for the PR and the review ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QEventLoop object,
event_loop, created inIPython/terminal/pt_intputhooks/qt.pyL58 is not deleted when exiting the scope as passingappto the constructor parents the object toapp. This creates a memory leak as QEventLoop objects are being accumulated.The issue was originally reported by @pag who also suggested the fix.
pytest IPython/terminal/tests/runs through without errors. I have tested the changes and see no more accumulation ofQEventLoopobjects.This fixes #14240