Fix for failing testsuite when using --with-xml-coverage on windows. #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See ipython#1428 for discussion.
|
If we really can get rid of this, then we no longer need the |
|
Is this ready, then? Does it close #1428? |
|
okay, then. |
minrk
added a commit
that referenced
this pull request
Mar 8, 2012
Fix for failing testsuite when using --with-xml-coverage on windows. This is necessary to get the shiningpanda testing on windows to work. Without the fix all tests fail.
|
Thomas skrev 2012-03-08 01:29:
/Jörgen |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix for failing testsuite when using --with-xml-coverage on windows. This is necessary to get the shiningpanda testing on windows to work. Without the fix all tests fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to get the shiningpanda testing on windows to work. Without the fix all tests fail. Using this fix I ran the tests and the results are up on:
https://jenkins.shiningpanda.com/ipython/job/ipython-windows-py27/1/
See #1428 for discussion.