store git commit hash in utils._sysinfo instead of hidden data file #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…info.ini data file.
| out_file.close() | ||
| out_pth = pjoin(self.build_lib, pkg_dir, 'utils', '_sysinfo.py') | ||
| with io.open(out_pth, 'w') as out_file: | ||
| for line in [ |
There was a problem hiding this comment.
Rather than looping manually, I'd just let the writelines method do it for us:
writelines([
u"# GENERATED BY setup.py\n",
u"commit = '%s'\n" % repo_commit,])
|
This looks good, with just a very minor tweak I suggested. I vastly prefer this to #1524, so I'll close that and we'll go with this solution instead. Thanks! |
|
now uses writelines |
fperez
added a commit
that referenced
this pull request
Apr 14, 2012
store git commit hash in utils._sysinfo instead of hidden data file Behavior is essentially unchanged, but the hash is stored in a generated Python file instead of hidden data file. Closes #1484.
fperez
added a commit
that referenced
this pull request
Apr 14, 2012
Unicode literals (u'foo') aren't valid in Python 3.{1,2} (they will be
again in 3.3, and I failed to notice this. This is a quick fix, will
discuss further on-list. But I want master to remain working for py3
users.
fperez
added a commit
that referenced
this pull request
Apr 17, 2012
Unicode literals (u'foo') aren't valid in Python 3.{1,2} (they will be
again in 3.3, and I failed to notice this. This is a quick fix, will
discuss further on-list. But I want master to remain working for py3
users.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
store git commit hash in utils._sysinfo instead of hidden data file Behavior is essentially unchanged, but the hash is stored in a generated Python file instead of hidden data file. Closes ipython#1484.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
…#1538) Unicode literals (u'foo') aren't valid in Python 3.{1,2} (they will be again in 3.3, and I failed to notice this. This is a quick fix, will discuss further on-list. But I want master to remain working for py3 users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior is essentially unchanged, but the hash is stored in a generated Python file instead of hidden data file.
Alternative to PR #1524
Closes #1484