attempt to suppress exceptions in channel threads at shutdown #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean shutdown could result in Attribute/TypeErrors in channel threads due to garbage collection of namespaces. Now try to ignore these exceptions if the shutdown process is detected.
|
Looks clean enough to me, thanks! Merging now. |
fperez
added a commit
that referenced
this pull request
Apr 14, 2012
Attempt to suppress exceptions in channel threads at shutdown.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Attempt to suppress exceptions in channel threads at shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shutdown of frontends (Qt, terminal console) could result in Attribute/TypeErrors in channel threads due to garbage collection cleaning up names. This tries to ignore these exceptions if the shutdown process is detected.