Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude UserDict when deep reloading NumPy. #1645

Merged
merged 1 commit into from Apr 23, 2012

Conversation

bfroehle
Copy link
Contributor

This prevents another test failure in IPython.lib.tests.test_irunner_pylab_magic::

Traceback (most recent call last):
...
  File "/usr/lib/python2.7/weakref.py", line 53, in __init__
    UserDict.UserDict.__init__(self, *args, **kw)
TypeError: unbound method __init__() must be called with UserDict instance as first argument (got WeakValueDictionary instance instead)

Closes #1636.

This prevents another test failure in IPython.lib.tests.test_irunner_pylab_magic::

    Traceback (most recent call last):
    ...
      File "/usr/lib/python2.7/weakref.py", line 53, in __init__
        UserDict.UserDict.__init__(self, *args, **kw)
    TypeError: unbound method __init__() must be called with UserDict instance as first argument (got WeakValueDictionary instance instead)

Closes ipython#1636.
@bfroehle
Copy link
Contributor Author

Overall this seems quite fragile, but suffices to fix the currently failing test on my system (Ubuntu 11.10).

In general, I think it'd be better to either:

  1. Isolate dreload(numpy) in its own subprocess; or
  2. Remove the dreload(numpy) test altogether.

@fperez
Copy link
Member

fperez commented Apr 23, 2012

@bfroehle, I'll try to isolate that in a separate test group, but given the current design of the testing code, that's a little tricky to do. In the meantime, this fixes a broken master test suite, so it's pretty high-priority to merge it; I hate having a failing master suite, b/c it easily masks other new failures.

Merging now, thanks!

fperez added a commit that referenced this pull request Apr 23, 2012
Exclude UserDict when deep reloading NumPy.

Closes #1636.
@fperez fperez merged commit e544c6d into ipython:master Apr 23, 2012
@takluyver
Copy link
Member

Since this change, an additional test failed on Python 2.6. Hopefully it's just another chance failure, as it looks unrelated, but if it fails again tonight we'll have to look into it:
https://jenkins.shiningpanda.com/ipython/job/ipython-multi/PLATFORM=debian6,PYTHON=CPython-2.6/75/testReport/junit/IPython.zmq.tests.test_message_spec/test_complete/test/

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Exclude UserDict when deep reloading NumPy.

Closes ipython#1636.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test_deepreload breaks pylab irunner tests
3 participants