Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecated warnings from ipython-qtconsole.desktop. #1695

Merged
merged 1 commit into from May 3, 2012

Conversation

bfroehle
Copy link
Contributor

@bfroehle bfroehle commented May 3, 2012

This fixes the warnings in .xsession-errors in Ubuntu 12.04.

Closes #1672.

@juliantaylor
Copy link
Contributor

not quite right yet:

$desktop-file-validate ipython-qtconsole.desktop 
ipython-qtconsole.desktop: error: value "Unity" for string list key "OnlyShowIn" in group "Desktop Action Pylab" does not have a semicolon (';') as trailing character
ipython-qtconsole.desktop: error: value "Unity" for string list key "OnlyShowIn" in group "Desktop Action Pylabinline" does not have a semicolon (';') as trailing character

@takluyver
Copy link
Member

With respect to OnlyShowIn: I don't know if any of the other desktop environments use desktop actions yet, but I don't think there's any need to make them Unity-specific from our end, so I suggest not using OnlyShowIn at all. I'd previously just copied and pasted from somewhere with the TargetEnvironment set.

@bfroehle
Copy link
Contributor Author

bfroehle commented May 3, 2012

Okay, let's try this again... :)

@takluyver
Copy link
Member

Thanks, that verifies now. @juliantaylor , any other thoughts? If you're happy, I think we can merge this.

@juliantaylor
Copy link
Contributor

one could still use the new icon instead of gnome-netstatus-idle

@takluyver
Copy link
Member

But we can't guarantee that our icon is in any particular location, so don't we have to refer to one that's already in place, and let you (with your packaging hat on) set it up with the correct icon?

@bfroehle
Copy link
Contributor Author

bfroehle commented May 3, 2012

Let's save the icon for a different PR.

takluyver added a commit that referenced this pull request May 3, 2012
Avoid deprecated warnings from ipython-qtconsole.desktop.
@takluyver takluyver merged commit c7e29e4 into ipython:master May 3, 2012
@takluyver
Copy link
Member

Agreed. I've merged this one.

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
…_desktop

Avoid deprecated warnings from ipython-qtconsole.desktop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipython-qtconsole.desktop is using a deprecated format
3 participants