Allow TryNext to have an error message without it affecting the command chain #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test results for commit cdd3c85 merged into master
Not available for testing: python2.6 |
|
The test failure on 3.2 is issue #1699, nothing to do with this pull request. |
| """ | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| def __init__(self, _msg="", *args, **kwargs): |
There was a problem hiding this comment.
Because you can give it keyword arguments to pass to the next function in the chain, and it's possible, if unlikely, that you might use msg as a keyword argument. So it deliberately looks special because it's handled differently to other keyword arguments.
|
Test results for commit cdd3c85 merged into master
Not available for testing: |
1 similar comment
|
Test results for commit cdd3c85 merged into master
Not available for testing: |
|
Seems sensible to me, merging. |
minrk
added a commit
that referenced
this pull request
May 9, 2012
Allow TryNext to have an error message without it affecting the command chain added as `_msg`, relaying `**kwargs` closes #211
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Allow TryNext to have an error message without it affecting the command chain added as `_msg`, relaying `**kwargs` closes ipython#211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-211