fixes #1708, failing test in arg_split on windows

[jstenar]

There were a conflicting defintion of CommandLineToArgvW.res_type in _process_win32 and _process_win32_controller. This PR fixes the issue.

[jstenar]

Apparently #1708 is a duplicate of #1632

[minrk]

Does this fix the actual issue, reported in #1632?

[jstenar]

Min RK skrev 2012-05-07 21:08:

Does this fix the actual issue, reported in #1632?

At least the steps that caused the crash, ls followed by cd .., does not
cause a crash anymore. So as far as I can tell it fixes the issue.

/Jörgen

[takluyver]

@jstenar : If you run the test suite against this branch, how many failures do you see? The last test on ShiningPanda had 7, so it should be less than that.

[jstenar]

Thomas Kluyver skrev 2012-05-07 21:43:

@jstenar : If you run the test suite against this branch, how many failures do you see? The last test on ShiningPanda had 7, so it should be less than that.

---

Reply to this email directly or view it on GitHub:
#1709 (comment)

There are fewer failures now and no new ones.

[takluyver]

Great. No objections from me, then. @minrk, if you're happy with this, go ahead and merge it.

[minrk]

Looks good to me, but I would like to wait for a quick confirmation from #1632 and then we can merge, closing that issue.

[minrk]

Test results for commit bbd1f50 merged into master
Platform: darwin

• python2.6: OK (libraries not available: matplotlib pymongo qt tornado wx wx.aui)
• python2.7: OK (libraries not available: wx wx.aui)
• python3.2: OK (libraries not available: matplotlib pymongo qt wx wx.aui)

Not available for testing: python3.1